Todo List

base

Kimono_Host::GetService()

• is this function redundant?

html_error_handler()

• remove instanceof check, this seems to have been an early php5 bug

Kimono_User::IsPermitted()

• fix permissions logging

Kimono_Error::isVisible()

• chicken-in-egg problem

kimono.php

• are there file/dir permissions to check for?

Kimono_Counter

• should probably check if callback function exists

Kimono_Error

• consider the use of debug_backtrace() to track errors more easily

kimono_ldap_auth()

• it seems atleast on OpenLDAP a failed ldap_connect() never returns FALSE, that was a bad server always returns "invalid user or password"

Kimono_Monitor

• the Get*() functions should maybe cache their results to avoid reloading objects

kimono_send_email()

• should we validate email addresses?
• ability to use another SMTP than system?

kimono_send_statistics()

• send language as well?

Kimono_Error::RegisterCallback()

• make it possible to register static class functions

Kimono_MCrypt::SetPassphrase()

• perhaps some kind of complexity check?

Kimono_RC4_Crypt::SetPassphrase()

• perhaps some kind of complexity check?

interface

kimono_add_host()

• probably needs to check for non-existent group

kimono_edit_config()

• validate the variables when setting config values

kimono_edit_notify_relations()

• check for permissions

kimono_header()

• [HTTP_ACCEPT_ENCODING] => gzip,deflate in $GLOBALS could be used to enable/disable gzip compression

kimono_show_permissions()

• print out read/write for each permission

kimono_snmp_walk()

• can only change group once now
• only load OIDs specified by the group chosen to speed up things

lang_svenska.php

• hosts=värdar isn't a good translation

Kimono_Daemon::UpdateServices()

• only Synchronize() if any services has been run this time

services

file.php

• should be able to check for files depending on date, e.g. file040608.txt

Kimono_Service_Ftp

• add support for SSL via ftp_ssl_connect(), remember to check if function exists (only does on OpenSSL-enabled PHP installs)

Kimono_Service_Ldap

• test this service!

Kimono_Service_MsSQL

• check for passwords longer than 10-15 characters and warn that connection might fail (see comment on http://se2.php.net/manual/en/function.mssql-connect.php)

Kimono_Service_SMTP

• does it matter what domain is specified in HELO?

Kimono_Service_DNS::Requirements()

• requires PEAR's Net_DNS

sql

Kimono_SQL_MySQL::Connect()

• test pros and cons of using persistent connections, mysql manual recommends it

Kimono_SQL_MySQL::DeleteHistory()

• needs to check for numeric-only values

Kimono_SQL_MySQL::GetConfig()

• sql query should have "GROUP BY C.name" but this mysteriously hides two config values?

Kimono_SQL_MySQL::GetGroups()

• is it really safe to use "id LIKE '$group_id'"?

Kimono_SQL_MySQL::GetPasswordRecovery()

• perhaps user should only get one attempt thus clearing the recovery fields after a failed attempt?

Kimono_SQL::GetRequiredTables()

• keep updated!

Kimono_SQL_MySQL

• check for privileges (SHOW PRIVILEGES)?

Kimono_SQL_MySQL::Prep()

• probably still a good idea to look for evil SQL queries like DROP DATABASE

Kimono_SQL_MySQL::ScheduleServices()

• in mysql-4.1 this could probably run regularly using CHECKSUM TABLE to find out if a table changed
• optimize this crap!

Kimono_SQL_MySQL::SetPermission()

• could save lots of sql queries by buffering these inserts and flush them at once

Kimono_SQL_MySQL::Synchronize()

• when removing hosts and groups, this function must be called
• use subqueries when a switch to mysql4.1+ is possible

xml

Kimono_XML_Document::toFile()

• make the xml_parse() upon save optional for speed improvement